[whimsy] branch master updated: Simplify; drop unused vars

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8be2d6c  Simplify; drop unused vars
8be2d6c is described below

commit 8be2d6ce151502714b0917a33dc4994de1723512
Author: Sebb <s...@apache.org>
AuthorDate: Sun Jan 12 22:21:50 2020 +0000

    Simplify; drop unused vars
---
 lib/whimsy/asf/ldap.rb | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 49f0dbe..e2669aa 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -198,7 +198,7 @@ module ASF
     def self.extract_cert
       host = hosts.sample[%r{//(.*?)(/|$)}, 1]
       puts ['openssl', 's_client', '-connect', host, '-showcerts'].join(' ')
-      out, err, rc = Open3.capture3 'openssl', 's_client',
+      out, _, _ = Open3.capture3 'openssl', 's_client',
         '-connect', host, '-showcerts'
       out[/^-+BEGIN.*?\n-+END[^\n]+\n/m]
     end
@@ -1023,16 +1023,12 @@ module ASF
 
     # return a list of ASF::People who are members of this group
     def members
-      members = weakref(:members) do
-        ASF.search_one(base, "cn=#{name}", 'memberUid').flatten
-      end
-
-      members.map {|uid| Person.find(uid)}
+      memberids.map {|uid| Person.find(uid)}
     end
 
     # return a list of ids who are members of this group
     def memberids
-      members = weakref(:members) do
+      weakref(:members) do
         ASF.search_one(base, "cn=#{name}", 'memberUid').flatten
       end
     end