This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 7786b29 Drop unused variables
7786b29 is described below
commit 7786b2991b74ac5aef9deba94fcf0985266f051f
Author: Sebb <[email protected]>
AuthorDate: Sun Jan 12 22:58:10 2020 +0000
Drop unused variables
---
lib/whimsy/asf/documents.rb | 2 +-
lib/whimsy/asf/git.rb | 2 +-
lib/whimsy/asf/icla.rb | 2 +-
lib/whimsy/asf/member.rb | 2 +-
lib/whimsy/asf/svn.rb | 5 +++--
5 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/whimsy/asf/documents.rb b/lib/whimsy/asf/documents.rb
index a1d19c2..f3b4978 100644
--- a/lib/whimsy/asf/documents.rb
+++ b/lib/whimsy/asf/documents.rb
@@ -49,7 +49,7 @@ module ASF
# Returns the basename or nil if no match
def self.match_claRef(claRef)
# Match either full name (e.g. directory) or stem (e.g. name.pdf)
- file = listnames.select{|l| l.chomp('/') == claRef ||
l.start_with?("#{claRef}.") }.map {|m| m.chomp('/')}.first
+ listnames.select{|l| l.chomp('/') == claRef ||
l.start_with?("#{claRef}.") }.map {|m| m.chomp('/')}.first
end
# is the name a directory?
diff --git a/lib/whimsy/asf/git.rb b/lib/whimsy/asf/git.rb
index 2e3d084..0f2b48e 100644
--- a/lib/whimsy/asf/git.rb
+++ b/lib/whimsy/asf/git.rb
@@ -55,7 +55,7 @@ module ASF
@repos = Hash[Dir[*git].map { |name|
next unless Dir.exist? name.untaint
Dir.chdir name.untaint do
- out, err, status =
+ out, _, status =
Open3.capture3(*%(git config --get remote.origin.url))
if status.success?
[File.basename(out.chomp, '.git'), Dir.pwd.untaint]
diff --git a/lib/whimsy/asf/icla.rb b/lib/whimsy/asf/icla.rb
index 76075a3..3854622 100644
--- a/lib/whimsy/asf/icla.rb
+++ b/lib/whimsy/asf/icla.rb
@@ -154,7 +154,7 @@ module ASF
# rearrange line in an order suitable for sorting
def self.lname(line)
return '' if line.start_with? '#'
- id, name, rest = line.split(':',3)
+ _, name, rest = line.split(':',3)
return '' unless name
# Drop trailing (comment string) or /* comment */
diff --git a/lib/whimsy/asf/member.rb b/lib/whimsy/asf/member.rb
index c1b947f..a54d899 100644
--- a/lib/whimsy/asf/member.rb
+++ b/lib/whimsy/asf/member.rb
@@ -99,7 +99,7 @@ module ASF
# extract member emails from members.txt entry
def self.emails(text)
- emails = text.to_s.scan(/Email: (.*(?:\n\s+\S+@.*)*)/).flatten.
+ text.to_s.scan(/Email: (.*(?:\n\s+\S+@.*)*)/).flatten.
join(' ').split(/\s+/).grep(/@/)
end
diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 8e09b0c..40d10c6 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -44,7 +44,7 @@ module ASF
@repos = Hash[Dir[*svn].map { |name|
next unless Dir.exist? name.untaint
Dir.chdir name.untaint do
- out, err, status = Open3.capture3('svn', 'info')
+ out, _, status = Open3.capture3('svn', 'info')
if status.success?
[out[/URL: (.*)/,1].sub(/^http:/,'https:'), Dir.pwd.untaint]
end
@@ -540,7 +540,8 @@ module ASF
return curtag, nil
else
open(listfile) do |l|
- filerev = l.gets.chomp
+ # fetch the file revision from the first line
+ _filerev = l.gets.chomp # TODO should we be checking _filerev?
if trimSlash
return curtag, l.readlines.map {|x| x.chomp.chomp('/')}
else
