[whimsy] branch master updated: Reuse code: only set up :members in one method

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 355d0ac  Reuse code: only set up :members in one method
355d0ac is described below

commit 355d0ac74514487a2888d74d277beaf013cbce06
Author: Sebb <s...@apache.org>
AuthorDate: Sat Jan 18 12:36:48 2020 +0000

    Reuse code: only set up :members in one method
---
 lib/whimsy/asf/ldap.rb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 49ce8ee..d537bcc 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1167,11 +1167,7 @@ module ASF
     # list of committers on this project.  Stored in LDAP as a <tt>member</tt>
     # attribute.
     def members
-      members = weakref(:members) do
-        ASF.search_one(base, "cn=#{name}", 'member').flatten
-      end
-
-      members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
+      memberids.map {|id| Person.find id}
     end
 
     # list of member ids in the project