This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5feaeae  Don't init ldap unnecessarily
5feaeae is described below

commit 5feaeaeb3ae12c6df0eb0a43e34a14c5cd7afa57
Author: Sebb <[email protected]>
AuthorDate: Wed Aug 4 13:08:21 2021 +0100

    Don't init ldap unnecessarily
---
 www/secretary/workbench/views/actions/memapp.json.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/secretary/workbench/views/actions/memapp.json.rb 
b/www/secretary/workbench/views/actions/memapp.json.rb
index 6cb2755..e276a2b 100644
--- a/www/secretary/workbench/views/actions/memapp.json.rb
+++ b/www/secretary/workbench/views/actions/memapp.json.rb
@@ -90,10 +90,10 @@ task "update cn=member,ou=groups,dc=apache,dc=org in LDAP" 
do
   end
 
   complete do
-    ldap = ASF.init_ldap(true)
     if ASF.memberids.include? @availid
       _transcript ["#@availid already in group member"]
     else
+      ldap = ASF.init_ldap(true)
       ldap.bind("uid=#{env.user},ou=people,dc=apache,dc=org",
         env.password)
 

Reply via email to