[whimsy] branch master updated: Not currently needed

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 269eb53  Not currently needed
269eb53 is described below

commit 269eb532a0dfb8afa4f1e266d3ed84a51d529b57
Author: Sebb <s...@apache.org>
AuthorDate: Fri Aug 20 17:35:35 2021 +0100

    Not currently needed
---
 www/secretary/workbench/views/forms/icla.js.rb | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/www/secretary/workbench/views/forms/icla.js.rb 
b/www/secretary/workbench/views/forms/icla.js.rb
index b7b9a56..89d07af 100644
--- a/www/secretary/workbench/views/forms/icla.js.rb
+++ b/www/secretary/workbench/views/forms/icla.js.rb
@@ -151,16 +151,17 @@ class ICLA < Vue
 
     @realname = name
     @pubname = parsed.PublicName || name
-    pubnamearray = @pubname.split(" ")
     @familyfirst = parsed.FamilyFirst || false
-    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
     @filename = self.genfilename(name, @familyfirst)
     @email = parsed.EMail || @@headers.from
     @user = parsed.ApacheID || ''
     project = parsed.Project
     @project = project if @@projects.include? project
     @pdfproject = parsed.PDFProject
+    # Not needed currently
+    # pubnamearray = @pubname.split(" ")
+    # @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    # @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
   end
 
   # TODO: should this be called by process_response() ?
@@ -252,17 +253,19 @@ class ICLA < Vue
   # when family first changes, update file name and LDAP default fields
   def changeFamilyFirst(event)
     @filename = self.genfilename(@realname, @familyfirst)
-    pubnamearray = @pubname.split(' ')
-    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
+    # not needed currently
+    # pubnamearray = @pubname.split(' ')
+    # @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    # @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
   end
 
   # when public name changes, update LDAP default fields
   def changePublicName(event)
     @pubname = event.target.value;
-    pubnamearray = @pubname.split(' ')
-    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
+    # not needed currently
+    # pubnamearray = @pubname.split(' ')
+    # @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    # @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
   end
 
   # generate file name from the real name