This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new aa23f8e Try suggestion from Sam
new 99add6e Merge branch 'master' of
https://gitbox.apache.org/repos/asf/whimsy
aa23f8e is described below
commit aa23f8e8b77b12029670fe89be133a2c85be926b
Author: Sebb <[email protected]>
AuthorDate: Fri Mar 25 23:25:38 2022 +0000
Try suggestion from Sam
---
.github/workflows/unittestagenda.yml | 5 +++++
Dockerfile | 17 ++++++++++++++++-
www/board/agenda/spec/navigate_spec.rb | 2 +-
3 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/unittestagenda.yml
b/.github/workflows/unittestagenda.yml
index 7886433..f4efb3c 100644
--- a/.github/workflows/unittestagenda.yml
+++ b/.github/workflows/unittestagenda.yml
@@ -42,6 +42,11 @@ jobs:
# need to run the ruby that has all the gems installed
run: |
sudo $(which ruby) -I $PWD/lib -r whimsy/asf -e "ASF::LDAP.configure"
+ - name: Tweak chromedriver
+ run: |
+ export DISPLAY=:99
+ chromedriver --url-base=/wd/hub &
+ sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
- name: test agenda code
run: |
cd www/board/agenda
diff --git a/Dockerfile b/Dockerfile
index 3774322..a77d47d 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -8,7 +8,7 @@ ENV GEM_HOME="/srv/gems" \
RUN apt-get update && \
apt-get install -y curl software-properties-common apt-utils && \
- curl -sL https://deb.nodesource.com/setup_12.x | bash - && \
+ curl -sL https://deb.nodesource.com/setup_14.x | bash - && \
echo "deb http://opensource.wandisco.com/ubuntu bionic svn110" > \
/etc/apt/sources.list.d/subversion.list && \
curl -sL http://opensource.wandisco.com/wandisco-debian-new.gpg | \
@@ -63,6 +63,21 @@ RUN DEBIAN_FRONTEND='noninteractive' apt-get install -y vim
# for checking ldap settings etc
RUN DEBIAN_FRONTEND='noninteractive' apt-get install -y ldap-utils
+# For testing agenda, you may need the following:
+# curl -sL https://dl-ssl.google.com/linux/linux_signing_key.pub | sudo
apt-key add -
+# sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable
main" >> /etc/apt/sources.list.d/google.list'
+# apt-get update
+# apt-get install -y google-chrome-stable
+# Find the chrome version:
+# google-chrome --version
+# Install chromedriver:
+# e.g. curl -o chromedriver.zip
https://chromedriver.storage.googleapis.com/99.0.4844.51/chromedriver_linux64.zip
+# unzip it:
+# unzip chromedriver.zip
+# mv chromedriver /usr/bin/chromedriver
+# chown root:root /usr/bin/chromedriver
+# chmod +x /usr/bin/chromedriver
+
# This should be last, as the source is likely to change
# It also takes very little time, so it does not matter if it has to be redone
# N.B. These files need to be allowed in the .dockerignore file
diff --git a/www/board/agenda/spec/navigate_spec.rb
b/www/board/agenda/spec/navigate_spec.rb
index 9de520d..4707eb0 100644
--- a/www/board/agenda/spec/navigate_spec.rb
+++ b/www/board/agenda/spec/navigate_spec.rb
@@ -8,7 +8,7 @@ feature 'navigation', js: true do
it "should navigate to the Cocoon report and back" do
skip "headless browser test not run on Travis" if ENV['TRAVIS']
# Looks like chromedriver cannot cope for some reason
- skip "headless browser test not run under GitHub Actions" if
ENV['GITHUB_ACTIONS']
+ # skip "headless browser test not run under GitHub Actions" if
ENV['GITHUB_ACTIONS']
visit '/2015-02-18/Clerezza'
expect(page).to have_selector '.navbar-fixed-top.reviewed .navbar-brand',
