This is an automated email from the ASF dual-hosted git repository.

clr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 6ada750b Add script font to message (#166)
6ada750b is described below

commit 6ada750b433cda0a477ea00207c9bf6af96c1dda
Author: Craig L Russell <[email protected]>
AuthorDate: Fri Jun 10 14:07:19 2022 -0700

    Add script font to message (#166)
    
    * Add script font to message
    
    Remove unsigned form from special action
    
    * Update incomplete.json.rb
    
    Add descriptions for script font and unsigned
---
 www/secretary/workbench/views/actions/incomplete.json.rb |  2 ++
 www/secretary/workbench/views/parts.js.rb                | 10 ++--------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/www/secretary/workbench/views/actions/incomplete.json.rb 
b/www/secretary/workbench/views/actions/incomplete.json.rb
index 31a3fc72..f7b979d8 100644
--- a/www/secretary/workbench/views/actions/incomplete.json.rb
+++ b/www/secretary/workbench/views/actions/incomplete.json.rb
@@ -24,6 +24,8 @@ REASONS = {
   '@wrong_identity' => 'the public key does not match the name/email on the 
form',
   '@validation_failed' => 'gpg validation failed',
   '@signature_not_armored' => 'gpg signature must be detached and 
ascii-armored',
+  '@unsigned' => 'the document appears to be unsigned',
+  '@script_font' => 'a name typed in a script font is not a signature',
 }
 
 # send rejection email
diff --git a/www/secretary/workbench/views/parts.js.rb 
b/www/secretary/workbench/views/parts.js.rb
index 4de0a741..54bda061 100644
--- a/www/secretary/workbench/views/parts.js.rb
+++ b/www/secretary/workbench/views/parts.js.rb
@@ -312,24 +312,18 @@ class Parts < Vue
                 _label do
                   _input type: 'checkbox', checked: @unsigned,
                   onClick: -> {@unsigned = !@unsigned}
-                  _span ' the document appears to be unsigned'
+                  _span ' unsigned'
                 end
               end
               _li do
                 _label do
                   _input type: 'checkbox', checked: @script_font,
                   onClick: -> {@script_font = !@script_font}
-                  _span ' a name typed in a script font is not a signature'
+                  _span ' script font'
                 end
               end
             end
 
-            _label do
-              _input type: 'radio', name: 'doctype', value: 'unsigned',
-                onClick: self.reject
-              _span 'unsigned form'
-            end
-
             _label do
               _input type: 'radio', name: 'doctype', value: 'resubmit',
                 onClick: self.reject

Reply via email to