[whimsy] branch master updated: WHIMSY-395 collated minutes specify incorrect VP

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 38c8a115 WHIMSY-395 collated minutes specify incorrect VP
38c8a115 is described below

commit 38c8a11589bbb928393b0ad9365fe44224412ad1
Author: Sebb <s...@apache.org>
AuthorDate: Tue Feb 28 11:21:49 2023 +0000

    WHIMSY-395 collated minutes specify incorrect VP
    
    Temporarily suppress erroneous owner attribution
---
 tools/collate_minutes.rb | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/collate_minutes.rb b/tools/collate_minutes.rb
index 254696a0..6d4d10d3 100755
--- a/tools/collate_minutes.rb
+++ b/tools/collate_minutes.rb
@@ -432,7 +432,8 @@ seen={}
   end
 
   # fill in comments from missing reports
-  ['Committee', 'Additional Officer'].each do |section|
+  # TODO: temporarily omit Additional Officer processing as it generates some 
incorrect ownership
+  ['Committee', '_Additional Officer_'].each do |section|
     reports = minutes[/^ \d\. #{section} Reports(\s*(\n|  .*\n)+)/,1]
     next unless reports
     reports.split(/^    (\w+)\./)[1..-1].each_slice(2) do |attach, comments|
@@ -441,6 +442,7 @@ seen={}
       next if comments.include? 'See Attachment'
       comments.sub! /.*\s+\n/, ''
       next if comments.empty?
+      # TODO: This does not work properly
       attach = ('A'..attach).count.to_s if section == 'Additional Officer'
 
       report = pending[attach] || OpenStruct.new
@@ -780,6 +782,12 @@ def layout(title = nil)
       beginning of every Board meeting; therefore, the list below does not
       normally contain details from the minutes of the most recent Board 
meeting.
       EOT
+      x.br
+      x.br
+      x.strong 'WARNING: these pages may omit some original contents of the 
minutes.'
+      x.br
+      x.text 'This is due to changes in the layout of the source minutes over 
the years.'
+      x.text 'Fixes are being worked on.'
     end
   }