This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 9080f84e Simplify
9080f84e is described below
commit 9080f84e91cff0c3bb97c3becfae11e53ac7247d
Author: Sebb <s...@apache.org>
AuthorDate: Wed Mar 1 11:16:47 2023 +0000
Simplify
---
tools/collate_minutes.rb | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/tools/collate_minutes.rb b/tools/collate_minutes.rb
index 04606926..e92d72ec 100755
--- a/tools/collate_minutes.rb
+++ b/tools/collate_minutes.rb
@@ -326,7 +326,7 @@ seen={}
next if text.strip.empty? and title =~ /Intentionally (left )?Blank/i
next if text.strip.empty? and title =~ /There is No/i
- report = pending[attach] || OpenStruct.new
+ report = pending[attach] ||= OpenStruct.new
report.meeting = date
report.attach = attach
report.owners ||= owners if owners
@@ -353,8 +353,6 @@ seen={}
report.attach = '@' + attach
end
- pending[attach] = report
-
if title == 'Incubator' and text
sections = text.split(/\nStatus [rR]eport (.*)\n=+\n/)
# Some minutes have a 'Detailed Reports' header before the first podling
report
@@ -433,12 +431,11 @@ seen={}
(.*?)\n # comments
\s\s\s\s?\w # separator
/mx).each do |owners,attach,comments|
- report = pending[attach] || OpenStruct.new
+ report = pending[attach] ||= OpenStruct.new
report.meeting = date
report.attach = attach
report.owners = owners
report.comments = comments.strip
- pending[attach] = report
end
# fill in comments from missing reports
@@ -455,12 +452,11 @@ seen={}
# TODO: This does not work properly
attach = ('A'..attach).count.to_s if section == 'Additional Officer'
- report = pending[attach] || OpenStruct.new
+ report = pending[attach] ||= OpenStruct.new
report.meeting = date
report.attach = attach
report.owners = owners
report.comments = comments.strip
- pending[attach] = report
end
end
