(whimsy) branch master updated: Fix up GH username for non-PMCs

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 4b3f2739 Fix up GH username for non-PMCs
4b3f2739 is described below

commit 4b3f2739258977551e600e296d9372b92ceae1c8
Author: Sebb <s...@apache.org>
AuthorDate: Tue Dec 19 13:18:41 2023 +0000

    Fix up GH username for non-PMCs
---
 www/roster/models/nonpmc.rb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/www/roster/models/nonpmc.rb b/www/roster/models/nonpmc.rb
index 19c0f258..1dec3440 100644
--- a/www/roster/models/nonpmc.rb
+++ b/www/roster/models/nonpmc.rb
@@ -73,7 +73,6 @@ class NonPMC
         unMatchedSecSubs.delete_if {|k| allMail.include? k.downcase}
       end
       roster[person.id]['ldap'] = true
-      roster[person.id]['githubUsername'] = (person.attrs['githubUsername'] || 
[]).join(', ')
     end
 
     committers.each do |person|
@@ -81,10 +80,13 @@ class NonPMC
         name: person.public_name,
         role: 'Committer'
       }
-      roster[person.id]['githubUsername'] = (person.attrs['githubUsername'] || 
[]).join(', ')
     end
 
-    roster.each {|k, v| v[:member] = ASF::Person.find(k).asf_member?}
+    roster.each do |k, v|
+      person = ASF::Person.find(k)
+      v[:member] = person.asf_member?
+      v['githubUsername'] = (person.attrs['githubUsername'] || []).join(', ')
+    end
 
     if cttee.chair and roster[cttee.chair.id]
       roster[cttee.chair.id]['role'] = 'Committee chair'