(whimsy) branch master updated: Show error details on failure

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 091507df Show error details on failure
091507df is described below

commit 091507df494f55c6e09da452fa6ba76348b8712e
Author: Sebb <s...@apache.org>
AuthorDate: Tue Apr 9 13:34:28 2024 +0100

    Show error details on failure
---
 www/members/page-scanner.cgi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/www/members/page-scanner.cgi b/www/members/page-scanner.cgi
index 81b7b073..04247a95 100755
--- a/www/members/page-scanner.cgi
+++ b/www/members/page-scanner.cgi
@@ -3,6 +3,8 @@ PAGETITLE = "ASF Page Asset Checker - ALPHA"
 
 # very rudimentary page asset checker - shows references to non-ASF assets
 
+require 'open3'
+
 # usage: whimsy.apache.org/members/page-scanner?url=http://apache.org/
 
 print "Content-type: text/plain; charset=UTF-8\r\n\r\n"
@@ -13,7 +15,13 @@ if qs =~ %r{^url=(https?://.+)}
   url = $1
   print "Checking the page #{url}\n\n"
   print "=====\n"
-  system('node', '/srv/whimsy/tools/scan-page.js', url, 'all')
+  cmd = ['node', '/srv/whimsy/tools/scan-page.js', url, 'all']
+  out, err, status = Open3.capture3(*cmd)
+  if status.success?
+    puts out
+  else
+    puts err.scan(/^Error:.+/) # Keep only the error line
+  end
   print "=====\n"
 else
   print "Expecting: ?url=http://.../\n";