This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new ac10dd8e Better check for https
ac10dd8e is described below
commit ac10dd8e09441bca751e7d5d7d700d982ce4035f
Author: Sebb <[email protected]>
AuthorDate: Mon Apr 28 00:57:46 2025 +0100
Better check for https
---
tools/pubsub-ci-email.rb | 2 +-
tools/pubsub2rake.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/pubsub-ci-email.rb b/tools/pubsub-ci-email.rb
index 2e4d2b21..b4f05342 100755
--- a/tools/pubsub-ci-email.rb
+++ b/tools/pubsub-ci-email.rb
@@ -48,7 +48,7 @@ class PubSub
uri = URI.parse(url)
Net::HTTP.start(uri.host, uri.port,
open_timeout: 20, read_timeout: 20, ssl_timeout: 20,
- use_ssl: url.match(/^https:/) ? true : false) do |http|
+ use_ssl: uri.scheme == 'https') do |http|
request = Net::HTTP::Get.new uri.request_uri
request.basic_auth(*creds) if creds
http.request request do |response|
diff --git a/tools/pubsub2rake.rb b/tools/pubsub2rake.rb
index 3318b34b..3a0ad9e9 100755
--- a/tools/pubsub2rake.rb
+++ b/tools/pubsub2rake.rb
@@ -31,7 +31,7 @@ class PubSub
uri = URI.parse(url)
Net::HTTP.start(uri.host, uri.port,
open_timeout: 20, read_timeout: 20, ssl_timeout: 20,
- use_ssl: url.match(/^https:/) ? true : false) do |http|
+ use_ssl: uri.scheme == 'https') do |http|
request = Net::HTTP::Get.new uri.request_uri
request.basic_auth(*creds) if creds
http.request request do |response|