This is an automated email from the ASF dual-hosted git repository.
clr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 0b60b575 Update reasons for rejecting a submission (#287)
0b60b575 is described below
commit 0b60b5756ad485369e80cd93c564a3d49fde94b4
Author: Craig L Russell <[email protected]>
AuthorDate: Sun Feb 8 07:48:48 2026 -0800
Update reasons for rejecting a submission (#287)
Add invalid form
Add invalid language
Add employee or grant
Add invalid legal name
Add reasons for four new rejections
---
.../workbench/views/actions/incomplete.json.rb | 4 +++
www/secretary/workbench/views/parts.js.rb | 36 ++++++++++++++++++++++
2 files changed, 40 insertions(+)
diff --git a/www/secretary/workbench/views/actions/incomplete.json.rb
b/www/secretary/workbench/views/actions/incomplete.json.rb
index 6cae4d13..64006aeb 100644
--- a/www/secretary/workbench/views/actions/incomplete.json.rb
+++ b/www/secretary/workbench/views/actions/incomplete.json.rb
@@ -18,6 +18,10 @@ REASONS = {
'@wrong_email' => 'email address shown in the ICLA must agree with the
sender',
'@corporate_postal' => 'the postal address does not appear to be a personal
residence address',
'@invalid_public' => 'the public name should be a real name or pen name and
not a user id',
+ '@invalid_name' => 'as this is a legal document, your full legal name is
required',
+ '@invalid_language' => 'the form must contain only English',
+ '@invalid_form' => 'please use a pdf form filler and attach a signature
image',
+ '@employee_or_grant' => 'the CCLA must include a list of employees and/or a
software grant',
'@separate_signature' => 'the document and signature must be sent attached
to the same email',
'@unauthorized_signature' => 'the signature must be from an authorized
person, usually a company executive',
'@empty_form' => 'the form appears to be completely empty',
diff --git a/www/secretary/workbench/views/parts.js.rb
b/www/secretary/workbench/views/parts.js.rb
index 17920aca..375b93ed 100644
--- a/www/secretary/workbench/views/parts.js.rb
+++ b/www/secretary/workbench/views/parts.js.rb
@@ -17,6 +17,10 @@ class Parts < Vue
@wrong_email = false
@corporate_postal = false
@invalid_public = false
+ @invalid_name = false
+ @invalid_language = false
+ @invalid_form = false
+ @employee_or_grant = false
@separate_signature = false
@unauthorized_signature = false
@empty_form = false
@@ -208,6 +212,10 @@ class Parts < Vue
_input type: 'hidden', name: 'wrong_email', value: @wrong_email
_input type: 'hidden', name: 'corporate_postal', value:
@corporate_postal
_input type: 'hidden', name: 'invalid_public', value:
@invalid_public
+ _input type: 'hidden', name: 'invalid_name', value: @invalid_name
+ _input type: 'hidden', name: 'invalid_language', value:
@invalid_language
+ _input type: 'hidden', name: 'invalid_form', value: @invalid_form
+ _input type: 'hidden', name: 'employee_or_grant', value:
@employee_or_grant
_input type: 'hidden', name: 'separate_signature', value:
@separate_signature
_input type: 'hidden', name: 'unauthorized_signature', value:
@unauthorized_signature
_input type: 'hidden', name: 'empty_form', value: @empty_form
@@ -301,6 +309,34 @@ class Parts < Vue
_span ' invalid public name'
end
end
+ _li do
+ _label do
+ _input type: 'checkbox', checked: @invalid_name,
+ onClick: -> {@invalid_name = !@invalid_name}
+ _span ' invalid legal name'
+ end
+ end
+ _li do
+ _label do
+ _input type: 'checkbox', checked: @invalid_language,
+ onClick: -> {@invalid_language = !@invalid_language}
+ _span ' invalid language'
+ end
+ end
+ _li do
+ _label do
+ _input type: 'checkbox', checked: @invalid_form,
+ onClick: -> {@invalid_form = !@invalid_form}
+ _span ' invalid form filler'
+ end
+ end
+ _li do
+ _label do
+ _input type: 'checkbox', checked: @employee_or_grant,
+ onClick: -> {@employee_or_grant = !@employee_or_grant}
+ _span ' employee or grant is needed'
+ end
+ end
_li do
_label do
_input type: 'checkbox', checked: @separate_signature,
