[
https://issues.apache.org/jira/browse/WICKET-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ate Douma updated WICKET-983:
-----------------------------
Attachment: wicket-1.3.0-beta3-portlet-support.patch
After creating a single complete patch file for all the changes I made to the
wicket-1.3.0-beta3-portlet-support branch, I started out trying to split off
small patches for easy review of the important changes to the wicket core.
But I found out this is almost impossible to do as several different type of
changes affect the same files/classes and breaking up my changes would take me
again at least several days.
As I've already described all the changes I made (and why) in separate subtasks
of the main WICKET-647 issue, I think a more realistic solution is that I try
to shortly summarize those changes and provide links to the related subtasks
for both further explanation as well as the commit history of the changes.
I think the only way to properly review all the changes, it is best to apply
them to a wicket-1.3.0-beta3 release (head) checkout.
For that purpose, I'm attaching a single full patch file.
After applying this in Eclipse, the changes can be easily be reviewed from the
Team Synchronizing perspective.
> Merge the portlet support branch into the trunk
> -----------------------------------------------
>
> Key: WICKET-983
> URL: https://issues.apache.org/jira/browse/WICKET-983
> Project: Wicket
> Issue Type: New Feature
> Components: wicket, wicket-portlet
> Affects Versions: 1.3.0-beta4
> Reporter: Ate Douma
> Assignee: Ate Douma
> Priority: Critical
> Fix For: 1.3.0-beta4
>
> Attachments: wicket-1.3.0-beta3-portlet-support.patch
>
>
> I will provide easy to review patches for all the core wicket changes
> required for merging the wicket-1.3.0-beta3-portlet-support branch back into
> trunk.
> Note: for efficiency reasons, I'll provide patches against the -beta3 release
> for now. When the merge plan is accepted I'll have to synchronize again with
> the latest trunk changes since the -beta3 release of course,
> but doing so already for just the review patches is going to delay more than
> I think is needed right now.
> As also indicated by Martijn Dashorst, the target for the merge is before the
> -beta4 cutoff as we hope to go to RC mode after that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
