[
https://issues.apache.org/jira/browse/WICKET-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530929
]
Martin Funk commented on WICKET-1016:
-------------------------------------
Hi Tauren,
the error I can't reproduce. I only see the warning.
Looks like I've been coding without reading, maybe I'll comeup with something
else on the weekend.
Btw, its not me, its them, who could commit. I'm just doing finger excercises
here.
Martin
> ExternalLink doesn't use model
> ------------------------------
>
> Key: WICKET-1016
> URL: https://issues.apache.org/jira/browse/WICKET-1016
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Tauren Mills
> Priority: Minor
> Attachments: ExternalLink.patch
>
>
> I don't understand why ExternalLink doesn't store the external href as
> the model. It stores it in an href property. It seems to not follow
> the normal wicket way.
> This makes it difficult to do things like display a link only if the
> model is not null. For instance:
> add(new ExternalLink("web", new PropertyModel(service,"web")) {
> @Override
> public boolean isVisible() {
> return getModelObject() != null;
> }
> });
> The problem is that getModelObject() is always null, because the
> PropertyModel is stored in the href property. And since isVisible()
> is part of Component, the href property isn't accessible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
