[ 
https://issues.apache.org/jira/browse/WICKET-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536523
 ] 

Matej Knopp commented on WICKET-1090:
-------------------------------------

Now this is rather a fundamental and I don't think it's right to change this 
behavior without any discussion. 
My usecase:

Submit a form with invalid input. Reload the page. 

or - even worse

Intermediate pages. 

"don't allow navigation to the intermediate screen when there are validation 
errors (like we do in teachscape btw), or use an model that can be updated even 
with 'wrong' values (e.g. use strings and do conversion later)."
You can't be serious with this. This would be a huge -1 from me. Don't allow 
intermediate pages without validation? But what if the field you select in 
intermediate page is required. Then you'll never get to it. 

If there are problems (e.g. with ajax) then we must resolve those problems. 
This is not a solution. 

> clean up raw_input after rendering of form components
> -----------------------------------------------------
>
>                 Key: WICKET-1090
>                 URL: https://issues.apache.org/jira/browse/WICKET-1090
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3, 1.3.0-beta4
>            Reporter: Eelco Hillenius
>            Assignee: Eelco Hillenius
>             Fix For: 1.3.0-beta5
>
>
> This code doesn't work like it should:
>   super("createUserForm", new CompoundPropertyModel(bean));
>   final TextField passwordField = new TextField("password");
>   passwordField.setOutputMarkupId(true);
>   passwordField.setLabel(new ResourceModel("label.createuser.password"));
>   add(passwordField);
>   add(new AjaxLink("generatePasswordLink") {
>     @Override
>     public void onClick(AjaxRequestTarget target) {
>       bean.setPassword(PasswordGenerator.generate().toString());
>       target.addComponent(passwordField);
>     }
>   });
> It should update the label with the new password, but it doesn't when done 
> after a form submit since it still has the raw_input value it got from that 
> last form submit. There is no reason (as far as I know) to hold on to that 
> value after rendering, so the fix is to clean the raw_input at the end of 
> requests (i.e. onAfterRender).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to