[
https://issues.apache.org/jira/browse/WICKET-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538389
]
Brill Pappin commented on WICKET-1108:
--------------------------------------
Yes, I realized it was a bug in the page code, but I don't like that I'm having
to initialize the components in the constructors. which prompted the
alternative suggestion.
IMO its pretty much an anti-pattern to do all that work in the constructors...
and if you think about it you realize that not only are you constructing the
model in your view component constructor, your inevitably doing logic in there
as the application gets more complex, which would definitely be an anti-pattern
in my book.
Sure, I can emulate it or design a new WebPage class that helps to avoid that
sort of thing, but why should I have to?
Anyway, something to think about. I'm going to close this particular issue
because the discussion should really be on the list and we've gone beyond the
scope of the original issue.
> Inherited Pages don't include components from super page.
> ---------------------------------------------------------
>
> Key: WICKET-1108
> URL: https://issues.apache.org/jira/browse/WICKET-1108
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Brill Pappin
> Assignee: Igor Vaynberg
> Fix For: 1.3.0-beta5
>
> Attachments: test-wicket-1108.zip
>
>
> I've got two pages:
> an abstract base page that has items included in all pages (BasePAge in this
> spike), and a concrete page (Index in this spike):
> - BasePage includes items like the title
> - Index only has content that applies to the index page.
> What I expected to happen was that the BasePage would include its components
> and the index page would include its one component.
> However when run, I get an error that not all the wicket tags have components.
> This was unexpected and counter intuitive to a java developer.
> Of course, being very new to Wicket, I may simply have done something wrong
> (which is why this is not marked as a bug).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.