Author: jcompagner
Date: Mon Oct 29 13:52:51 2007
New Revision: 589850
URL: http://svn.apache.org/viewvc?rev=589850&view=rev
Log:
implemented TODO so the check is only done in development
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java?rev=589850&r1=589849&r2=589850&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java
Mon Oct 29 13:52:51 2007
@@ -20,6 +20,7 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.markup.MarkupStream;
import org.apache.wicket.markup.html.WebMarkupContainer;
@@ -125,23 +126,24 @@
{
onPopulate();
- // TODO possibly enable this only in development mode
- Iterator i = iterator();
- while (i.hasNext())
+ if
(Application.get().getConfigurationType().equals(Application.DEVELOPMENT))
{
- Component c = (Component)i.next();
- Matcher matcher =
SAFE_CHILD_ID_PATTERN.matcher(c.getId());
- if (!matcher.matches())
+ Iterator i = iterator();
+ while (i.hasNext())
{
- log.warn("Child component of repeater " +
getClass().getName() + ":" + getId() +
- " has a non-safe child id of "
+ c.getId() +
- ". Safe child ids must be
composed of digits only.");
- // do not flood the log
- break;
- }
+ Component c = (Component)i.next();
+ Matcher matcher =
SAFE_CHILD_ID_PATTERN.matcher(c.getId());
+ if (!matcher.matches())
+ {
+ log.warn("Child component of repeater "
+ getClass().getName() + ":" + getId() +
+ " has a non-safe child
id of " + c.getId() +
+ ". Safe child ids must
be composed of digits only.");
+ // do not flood the log
+ break;
+ }
+ }
}
-
super.onBeforeRender();
}
