[
https://issues.apache.org/jira/browse/WICKET-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538890
]
Johan Compagner commented on WICKET-382:
----------------------------------------
but the choicerendere is doing the conversion:
Object displayValue =
getChoiceRenderer().getDisplayValue(choice);
Class objectClass = displayValue == null ? null :
displayValue.getClass();
// Get label for choice
final String label =
getConverter(objectClass).convertToString(displayValue,
getLocale());
only the result of the choice renderer is trying to be converted to a String
value, If the choice renderer already gives a string
then that will most likely be returned.
So what are you saying we should really just cast or call toString() on the
display value?
I think the current way is pretty good.
> Converter misusage/mangling in RadioChoice
> ------------------------------------------
>
> Key: WICKET-382
> URL: https://issues.apache.org/jira/browse/WICKET-382
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Alastair Maw
> Assignee: Johan Compagner
> Fix For: 1.3.0-beta5
>
>
> 1.x RadioChoice:433 is doing conversion. I don't think it should be.
> I think the default ChoiceRenderer should be doing the conversion, and that
> if you supply your own, no conversion should be done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
