[
https://issues.apache.org/jira/browse/WICKET-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Compagner closed WICKET-382.
----------------------------------
Resolution: Fixed
ok thats fine with me, so if it is string we dont convert anything else we do
I hope nobody wants to really convert again.
I have a major dejavu now of a discussion of the oposite side.
That people do expect that the choice rendere shouldn't do the conversion
thats why getDisplayValue returns an object and not directly a string i changed
that way back in jan 2006
see revision 458725.
But i changed this in all places where that same kind of code was used.
Now i hope we don't broke some once code (the one that does want a string to be
converted again
lets say format it differently.....)
We should have a bit more unit test for this thing i think...
> Converter misusage/mangling in RadioChoice
> ------------------------------------------
>
> Key: WICKET-382
> URL: https://issues.apache.org/jira/browse/WICKET-382
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Alastair Maw
> Assignee: Johan Compagner
> Fix For: 1.3.0-beta5
>
>
> 1.x RadioChoice:433 is doing conversion. I don't think it should be.
> I think the default ChoiceRenderer should be doing the conversion, and that
> if you supply your own, no conversion should be done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
