[
https://issues.apache.org/jira/browse/WICKET-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539377
]
Chuck Deal commented on WICKET-1121:
------------------------------------
Sorry, I didn't mean to imply that I had some special escaping code. I simply
needed to change the arguments to Strings.escapeMarkup() where I wanted to set
escapeSpaces to true instead of the default false. Without the refactoring, I
had to capture the whole method to make that small change. I chose to refactor
that out instead of introduce another argument/parameter for greater long-term
flexibility.
I've had this change in my codebase for a while, so I thought I'd see if it
could make it onto the mainline.
> Slight AbstractChoice refactoring
> ---------------------------------
>
> Key: WICKET-1121
> URL: https://issues.apache.org/jira/browse/WICKET-1121
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Chuck Deal
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.3.0-beta5
>
> Attachments: AbstractChoice.java.patch
>
>
> I have had the need to change the way that options were escaped. I found
> that in order to change the settings, I had to override (and cut-n-paste the
> entire method) the appendOptionHtml() method to make the small fix. The
> change I propose is to refactor the escaping code to another method for
> easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
