[
https://issues.apache.org/jira/browse/WICKET-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Compagner closed WICKET-1172.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-rc2
I made 2 unit test one for the border and one for the indicator.
The indicator did fail as you described, but the border did work fine.
I fixed the indicator problem.
> FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
> ------------------------------------------------------------------------
>
> Key: WICKET-1172
> URL: https://issues.apache.org/jira/browse/WICKET-1172
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Reporter: Dmitry Rzhevskiy
> Assignee: Johan Compagner
> Priority: Critical
> Fix For: 1.3.0-rc2
>
> Attachments: IndicatorTest.java
>
>
> FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator
> always invisible because:
> first render forms contain no errors,
> method FormComponentFeedbackIndicator.onBeforeRender (line 78) sets
> component invisible.
> onBeforeRender() not call for invisible components.
> workaround: override isVisible method :
> @Override
> public boolean isVisible() {
> return
> Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
> }
> method onBeforeRender don't need override in
> org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator
> same situation with FormComponentFeedbackBorder .
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
