[
https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547402
]
Juergen Donnerstag commented on WICKET-1105:
--------------------------------------------
a few more comments:
- it is onDetach() not afterRender().
- since onDetach() catches all exceptions but doesn't forward them, which means
no error page, logging is probably the best we can do.
- there are 2 test cases in our test base which now print such a error message
but since log.error is disabled you won't see them
- this is not a comprehensive test. If you replace or remove components which
want to contribute to the header than they are not detected. And we are not
testing everything, just webpages (no ajax calls)
- one of the problems is that basically all beahvors (AbstractBehavior)
implement IHeaderContributor and thus you can test for components and behavior
which implement that interface. You must actually test whether they write
something to the header response.
> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
> Key: WICKET-1105
> URL: https://issues.apache.org/jira/browse/WICKET-1105
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
> Reporter: Michal Capo
> Assignee: Juergen Donnerstag
> Fix For: 1.3.0-rc2
>
> Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is
> one difference in the markup.
> First:
> <head>
> <link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> <span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> <span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one
> rendered page contains reference to 'wicket-ajax.js' file but in the second
> not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
