Author: ivaynberg
Date: Sat Dec 15 10:44:08 2007
New Revision: 604485

URL: http://svn.apache.org/viewvc?rev=604485&view=rev
Log:
WICKET-1221 required check doesnt really make sense for checkboxes

Modified:
    
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java

Modified: 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java?rev=604485&r1=604484&r2=604485&view=diff
==============================================================================
--- 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
 Sat Dec 15 10:44:08 2007
@@ -191,8 +191,8 @@
                                // NOTE: do not encode the url as that would 
give invalid
                                // JavaScript
                                tag.put("onclick", "window.location.href='" + 
url +
-                                               (url.toString().indexOf('?') > 
-1 ? "&" : "?") + getInputName() +
-                                               "=' + this.checked;");
+                                       (url.toString().indexOf('?') > -1 ? 
"&" : "?") + getInputName() +
+                                       "=' + this.checked;");
                        }
 
                }
@@ -222,7 +222,15 @@
                catch (StringValueConversionException e)
                {
                        throw new ConversionException("Invalid boolean input 
value posted \"" + getInput() +
-                                       "\"", e).setTargetType(Boolean.class);
+                               "\"", e).setTargetType(Boolean.class);
                }
+       }
+
+       /**
+        * @see org.apache.wicket.markup.html.form.FormComponent#checkRequired()
+        */
+       public boolean checkRequired()
+       {
+               return true;
        }
 }


Reply via email to