Author: jcompagner
Date: Sun Dec 16 09:29:48 2007
New Revision: 604656
URL: http://svn.apache.org/viewvc?rev=604656&view=rev
Log:
code cleanup: WICKET-830
Modified:
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WebResponse.java
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/converters/CharacterConverter.java
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/io/SerializableChecker.java
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/SelectPage.java
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails.java
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/stockquote/StockQuote.java
Modified:
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
(original)
+++
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
Sun Dec 16 09:29:48 2007
@@ -89,7 +89,7 @@
while (iter.hasNext())
{
String next = (String)iter.next();
- buffer.append(" " + next.toString() +
"=\"" +
+ buffer.append(" " + next + "=\"" +
additionalAttributesMap.get(next).toString() + "\"");
}
}
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java
Sun Dec 16 09:29:48 2007
@@ -135,7 +135,7 @@
// remember the current setting
to be reset after the
// region
- autolinkStatus.push(new
Boolean(autolinking));
+
autolinkStatus.push(Boolean.valueOf(autolinking));
}
// html allows to represent true in
different ways
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WebResponse.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WebResponse.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WebResponse.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WebResponse.java
Sun Dec 16 09:29:48 2007
@@ -201,7 +201,7 @@
if (httpServletResponse != null)
{
// encode to make sure no caller forgot this
- url =
httpServletResponse.encodeRedirectURL(url).toString();
+ url =
httpServletResponse.encodeRedirectURL(url);
try
{
if (httpServletResponse.isCommitted())
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/converters/CharacterConverter.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/converters/CharacterConverter.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/converters/CharacterConverter.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/converters/CharacterConverter.java
Sun Dec 16 09:29:48 2007
@@ -41,15 +41,14 @@
*/
public Object convertToObject(final String value, Locale locale)
{
- final String stringValue = value.toString();
- int length = stringValue.length();
+ int length = value.length();
if (length == 0)
{
return null;
}
else if (length == 1)
{
- return new Character(value.toString().charAt(0));
+ return new Character(value.charAt(0));
}
throw newConversionException("Cannot convert '" + value + "' to
Character", value, locale);
}
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/io/SerializableChecker.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/io/SerializableChecker.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/io/SerializableChecker.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/io/SerializableChecker.java
Sun Dec 16 09:29:48 2007
@@ -339,8 +339,8 @@
if (!(obj instanceof Serializable) &&
(!Proxy.isProxyClass(cls)))
{
- throw new
WicketNotSerializableException(toPrettyPrintedStack(obj.getClass().getName())
- .toString(), exception);
+ throw new WicketNotSerializableException(
+
toPrettyPrintedStack(obj.getClass().getName()), exception);
}
ObjectStreamClass desc;
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
Sun Dec 16 09:29:48 2007
@@ -1116,8 +1116,8 @@
// If there haven't been found any event behaviors on the
component
// which matches the parameters we fail.
- failMessage = "No AjaxEventBehavior found on component: " +
component.getId() +
- " which matches the event: " + event.toString();
+ failMessage = "No AjaxEventBehavior found on component: " +
+ component.getId() + " which matches
the event: " + event;
notNull(failMessage, ajaxEventBehavior);
// initialize the request only if needed to allow the user to
pass
Modified:
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/SelectPage.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/SelectPage.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/SelectPage.java
(original)
+++
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/SelectPage.java
Sun Dec 16 09:29:48 2007
@@ -105,7 +105,7 @@
private static class Input implements IClusterable
{
/** the selected sites. */
- public String site = new String("sd");
+ public String site = "sd";
/** the selected choices. */
public List choices = new ArrayList();
Modified:
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java
(original)
+++
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java
Sun Dec 16 09:29:48 2007
@@ -65,9 +65,6 @@
*/
public Home()
{
- // Get our custom application subclass
- final ImagesApplication application =
(ImagesApplication)getApplication();
-
// Image as package resource
add(new Image("image2"));
Modified:
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails.java
(original)
+++
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails.java
Sun Dec 16 09:29:48 2007
@@ -54,8 +54,6 @@
*/
public BookDetails(final Book book)
{
- Model bookModel = new Model(book);
-
add(new Label("title", book.getTitle()));
add(new Label("author", book.getAuthor()));
add(new Label("fiction", Boolean.toString(book.getFiction())));
Modified:
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/stockquote/StockQuote.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/stockquote/StockQuote.java?rev=604656&r1=604655&r2=604656&view=diff
==============================================================================
---
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/stockquote/StockQuote.java
(original)
+++
wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/stockquote/StockQuote.java
Sun Dec 16 09:29:48 2007
@@ -146,7 +146,7 @@
private void writeRequest(String message, HttpURLConnection httpConn)
throws IOException
{
OutputStream out = httpConn.getOutputStream();
- out.write(message.toString().getBytes());
+ out.write(message.getBytes());
out.close();
}
