[
https://issues.apache.org/jira/browse/WICKET-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552703
]
Sebastiaan van Erk commented on WICKET-1017:
--------------------------------------------
It's a beautiful fix, it took me a while to understand it. :-)
Double.MIN_VALUE is *REALLY* counterintuitive (especially considering
Integer.MIN_VALUE).
bsh % -1.0 < Double.MIN_VALUE;
<true>
bsh % -1 < Integer.MIN_VALUE;
<false>
I still think it's a good idea to deprecate POSITIVE and NEGATIVE as Igor
suggested and at least cleary mention the API change, because there will
probably be people depending on the old behavior.
> POSITIVE and NEGATIVE in NumberValidator are badly named (or contain a bug)
> ---------------------------------------------------------------------------
>
> Key: WICKET-1017
> URL: https://issues.apache.org/jira/browse/WICKET-1017
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Sebastiaan van Erk
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.3.0-rc3
>
>
> The POSITIVE validator is a new number validator with minimum 0.
> However 0 is not positive. Therefore, the validator should be called
> NONNEGATIVE. That or it should not allow 0.
> The validation messages (at least in Dutch) state that the number must be
> LARGER than 0 if I enter a negative number.
> However, 0 is of course accepted.
> Thus, for consistency I think it would probably be best to fix this one way
> or the other.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
