Author: jdonnerstag Date: Wed Dec 26 14:55:52 2007 New Revision: 606968 URL: http://svn.apache.org/viewvc?rev=606968&view=rev Log: wicket-1224: PopupCloseLink broken with 1.3.0-rc2 in Internet Explorer
It was changed as part of wicket-1139 but IE doesn't like it. In order to avoid the problem I usually add to my apps getMarkupSettings().setStripXmlDeclarationFromOutput(true); and <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> I wonder if especially setStripXmlDeclarationFromOutput(true) wouldn't be a better default due to IE problems. The http header still contains the encoding. I leave this case open until we found a fix for both problem, but remove the xml declaration for the file to work properly Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/PopupCloseLink$ClosePopupPage.html Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/PopupCloseLink$ClosePopupPage.html URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/PopupCloseLink%24ClosePopupPage.html?rev=606968&r1=606967&r2=606968&view=diff ============================================================================== --- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/PopupCloseLink$ClosePopupPage.html (original) +++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/PopupCloseLink$ClosePopupPage.html Wed Dec 26 14:55:52 2007 @@ -1,4 +1,6 @@ -<?xml version="1.0" encoding="UTF-8" ?> +<!-- Without getMarkupSettings().setStripXmlDeclarationFromOutput(true) this line confuses IE (quirks mode) + ?xml version="1.0" encoding="UTF-8" ? +--> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with
