[
https://issues.apache.org/jira/browse/WICKET-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edvin Syse updated WICKET-1246:
-------------------------------
Description:
Today, all markup from the Choice-model is escaped in the appendOptionHtml
method of AbstractChoice. This makes it hard to include raquo, copyright
symbols etc to the option markup.
My suggestion is to add a method called escapeOptionMarkup() to AbstractChoice,
and let it return true by default. Then change the following line in
appendOptionHtml (Line 395/Wicket 1.3-rc2):
CharSequence escaped = Strings.escapeMarkup(display, false, true);
.. so that it checks the escapeOptionMarkup value before escaping.
This would be completely non-intrusive to existing code, and make it easy to
avoid escaping by overriding escapeOptionMarkup() when you need it.
-- Edvin Syse
was:
Today, all markup from the Choice-model is escaped in the appendOptionHtml
method of AbstractChoice. This makes it hard to include raquo, copyright
symbols etc to the option markup.
My suggestion is to add a method called escapeOptionMarkup() to AbstractChoice,
and let it return true by default. Then change the following line in
appendOptionHtml (Line 395/Wicket 1.3-rc2):
CharSequence escaped = Strings.escapeMarkup(display, false, true);
.. so that it cheks escapeOptionMarkup() before escaping.
This would be completely non-intrusive to existing code, and make it easy to
avoid escaping by overriding escapeOptionMarkup() when you need it.
-- Edvin Syse
Affects Version/s: 1.3.0-rc2
> RFE: Option to escape markup in AbstractChoice#appendOptionHtml
> ---------------------------------------------------------------
>
> Key: WICKET-1246
> URL: https://issues.apache.org/jira/browse/WICKET-1246
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-rc2
> Reporter: Edvin Syse
> Priority: Trivial
>
> Today, all markup from the Choice-model is escaped in the appendOptionHtml
> method of AbstractChoice. This makes it hard to include raquo, copyright
> symbols etc to the option markup.
> My suggestion is to add a method called escapeOptionMarkup() to
> AbstractChoice, and let it return true by default. Then change the following
> line in appendOptionHtml (Line 395/Wicket 1.3-rc2):
> CharSequence escaped = Strings.escapeMarkup(display, false, true);
> .. so that it checks the escapeOptionMarkup value before escaping.
> This would be completely non-intrusive to existing code, and make it easy to
> avoid escaping by overriding escapeOptionMarkup() when you need it.
> -- Edvin Syse
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
