[
https://issues.apache.org/jira/browse/WICKET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Hamblen updated WICKET-1166:
-----------------------------------
Attachment: submit-method-javadoc.patch
I'm not sure where the formal requirements would be, but I do find the method's
documentation misleading for the current behavior: "Gets the method used to
submit the form." As I've said I think it's a reasonable solution to just
update the javadocs, so, here's a patch that does that.
In the longer run I still think it would be better to lock down the submit
process a little more. The same reasons that that is difficult are the reasons
I think it should be done: with ajax and nesting, forms have become a pretty
fuzzy concept in Wicket. For a user looking at the API it's not clear what will
happen under various scenarios. But, that's just my opinion. Feel free to close
with or without this javadoc patch.
> add sanity check on form submit for request method
> --------------------------------------------------
>
> Key: WICKET-1166
> URL: https://issues.apache.org/jira/browse/WICKET-1166
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Safari 3
> Reporter: Nathan Hamblen
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.3.2
>
> Attachments: submit-method-javadoc.patch, submit-method.patch
>
>
> When refreshing a frameset that includes an already POST submitted Wicket
> form in a frame, using the redirect to render strategy, Safari erroneously
> requests the form's original target by GET, rather than the location that was
> eventually redirected to. Therefore none of the form values are available in
> the request object and NPEs will occur trying to access them in places like
> AbstractConverter.java:55.
> Because Form allows for a particular request method to be specified, I think
> it should also confirm that the expected method was used instead of waiting
> for an NPE in validation. The outcome is the same, but the cause of the error
> (the client) would be more evident in server logs, etc. Patch to come...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
