[
https://issues.apache.org/jira/browse/WICKET-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Compagner closed WICKET-1444.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.3
we just clone all NumberFormats before returning them.
I think this is the fastest and safest way to do it.
> AbstractDecimalConverter has a numberFormats fields that holds NumberFormats,
> But those are not thread save...
> --------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-1444
> URL: https://issues.apache.org/jira/browse/WICKET-1444
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Johan Compagner
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> We really should remove that map because now they can be used multi threaded
> because for example the DoubleConverter has a static INSTANCE variable..
> The AbstractIntegerConverter doesnt do that caching for example, that returns
> a new Format instance everytime.
> The problem is that we can remove that map just fine, expects that we have
> setNumberFormat(Locale,Format) method
> thats is a method that is very wrong because ot the caching, And they should
> use/override getNumberFormat when you call setNumberFormat..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
