[ 
https://issues.apache.org/jira/browse/WICKET-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584650#action_12584650
 ] 

Juergen Donnerstag commented on WICKET-1436:
--------------------------------------------

Just some thoughts: currently ComponentStringResourceLoader contains a constant 
with "properties,xml" which is the list of file extensions. But it is 
PropertiesFactory which loads the properties based on the file extension. 
ComponentStringResourceLoader uses the list to iterate over all possible 
resource include path, class name, style, locale and file extension. I think I 
would refactor that and remove file extensions from the resource iterator, put 
it into PropertiesFactory instead and factor out the code to load properties 
from *.properties and *.xml into IPropertyLoaders. Thus allowing users to add 
their own. Each IPropertyLoaders would be associated with a file extension. 

But it still doesn't solve the problem of xml markup and xml properties files. 
I think we have two options: a) an application (or PropertiesFactory) wide 
setting which is rather inflexible or b) per Component. The latter would either 
require a new Component method (get/setPropertiesFactory) or at least some kind 
of interface to be implemented by Component if a specific Component whishes to 
deviate from the standard.

As interim (1.3.3) solution we could add 
PropertiesFactory.get/setPropertyFileExtenstions() to allow any user to remove 
(not add or modify) an entry from the list.

> Unable to use properties file when generating XML files
> -------------------------------------------------------
>
>                 Key: WICKET-1436
>                 URL: https://issues.apache.org/jira/browse/WICKET-1436
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.1
>         Environment: OSX, Jetty
>            Reporter: Nick Heudecker
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.5-M1
>
>
> Please refer to this thread: 
> http://www.nabble.com/Unable-to-use-wicket:message-when-generating-XML-files-td15779276.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to