[ 
https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596905#action_12596905
 ] 

knopp edited comment on WICKET-987 at 5/14/08 12:05 PM:
--------------------------------------------------------------

Okay, with whole file i can see it. But the problem is before that line. This 
regex breaks the stripper
/\[((?:[\w-]*:)?[\w-]+)\s*(?:([!^$*~|]?=)\s*((['"])([^\4]*?)\4|([^'"][^\]]*?)))?\]/


      was (Author: knopp):
    Okay, with whole file i can see it. But the problem is before that line.
  
> Stripping javascript comments and whitespace breaks application when using 
> prototype library
> --------------------------------------------------------------------------------------------
>
>                 Key: WICKET-987
>                 URL: https://issues.apache.org/jira/browse/WICKET-987
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
>         Environment: wicket-1.3.0-beta3, 
> wicketstuff-scriptaculous-1.3-SNAPSHOT
>            Reporter: Ryan Sonnek
>            Assignee: Matej Knopp
>            Priority: Blocker
>             Fix For: 1.3.0-beta4
>
>         Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get 
> javascript errors loading my prototype.js file.  Since wicket automatically 
> enables this setting when in "DEPLOYMENT" mode, this is a real show stopper 
> for releasing my app.
> This has been talked about recently, but I would recommend using an 
> "official" javascript minification library instead of this home rolled 
> implementation.  The YUI compressor seems to be correctly licensed and would 
> be a great option, but I don't care as long as this is fixed. see WICKET-918 
> for more info
> attaching sample project that exhibits the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to