[
https://issues.apache.org/jira/browse/WICKET-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604670#action_12604670
]
Timo Rantalaiho commented on WICKET-550:
----------------------------------------
So the idea is that WebRequestEncoder should always create a properly encoded
query string with ?:s and &:s in their place?
Does WebRequestEncoder need some changes to be usable everywhere? I tried using
it in MockHttpServletRequest.getQueryString(), and a couple of tests started
failing right away, something to do with null values.
I got it working in RequestCycle.urlFor() though, and committed that. But I
couldn't easily find other relevant placed where WebRequestEncoder could be
used right away; for example in RequestCycle.urlFor() you need a non-encoding
version of essentially the same stuff in some other situation...
It seems that to get this cleaned up properly, we need a WicketUrl or some such
class that can encapsulate the different URL mungling.
> Use WebRequestEncoder everywhere a query string is constructed
> --------------------------------------------------------------
>
> Key: WICKET-550
> URL: https://issues.apache.org/jira/browse/WICKET-550
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Jean-Baptiste Quenot
> Fix For: 1.4-M3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
