[
https://issues.apache.org/jira/browse/WICKET-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1702.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg
> WicketMessageResolver should use application settings instead of a static
> property to configure its behavior
> ------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-1702
> URL: https://issues.apache.org/jira/browse/WICKET-1702
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1, 1.4-M2
> Reporter: Martin Benda
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4-M3
>
>
> The org.apache.wicket.markup.resolver.WicketMessageResolver uses a static
> property named "throwExceptionIfPropertyNotFound" to configure its behavior
> when the message resource key is not found (it either uses the default value
> or throws an exception). It is a bad practice to use static class properties
> in a framework library in such manner. Moreover, it may cause some wicket
> unit tests fail - see
> http://www.nabble.com/SimplePageTest-and-WicketMessageResolverTest-hidden-dependency-to17864543.html.
> IMHO an IResourceSettings property should be used insted of that static
> property - I'm not sure if the "throwExceptionOnMissingResource" is the right
> one or a new settings property should be created for this purpose - let the
> wicket devs decide.
> I can prepare a patch if you decide how the best solution should look like.
> Regards,
> Bendis
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
