[ 
https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timo Rantalaiho updated WICKET-579:
-----------------------------------

    Fix Version/s:     (was: 1.4-M4)
                   1.5-M1

This is a new feature so belongs to 1.5, right?

I'm also unsure of whether this would a good idea. Rolling your own 
DataTable-like class might be better, but if this is something very reusable, 
maybe it could be its own class apart from DataTable?

There's too much discussion in this issue to follow :) Maybe you can bring this 
up on the mailing lists if the issue is still interesting. Judging from the 
votes and watches it is?

> Need for DataTable not to require size
> --------------------------------------
>
>                 Key: WICKET-579
>                 URL: https://issues.apache.org/jira/browse/WICKET-579
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket, wicket-extensions
>    Affects Versions: 1.3.0-beta1
>         Environment: 1.3 snapshot dated 4/25
>            Reporter: Kurt Roekle
>             Fix For: 1.5-M1
>
>         Attachments: WICKET-578.patch, wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts 
> performance and scalability (not to mention, it wont be accurate in a system 
> when a lot of updates/deletes are taking place).  I had hoped to be able to 
> code just a new toolbar and DataProvider that would fix this, but I found I 
> needed changes in DataTable and  AbstractPageableView due to the fact 
> AbstractPageableView caches the row count.  I've made fixes for DataTable and 
> AbstractPageableView and I've included one new interface that would be 
> required.  I've also added an implementation of a new toolbar and 
> DataProvider that will enable DataTable to work without size (I've also 
> included a modified NavigationToolbar (and friends) that could be implemented 
> instead of a new toolbar.  I've tested these changes with my limited 
> knowledge of wicket and they seem to not break any existing code.  I 
> currently can't give you a diff, but the line #'s that changed are as follows:
>   
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to