[
https://issues.apache.org/jira/browse/WICKET-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611190#action_12611190
]
Stefan Fußenegger commented on WICKET-1679:
-------------------------------------------
I had my proposed fix in production for while now and it works very well. Could
this please be fixed? It absolutely is a no-brainer!
> Memory leak in DiskPageStore
> ----------------------------
>
> Key: WICKET-1679
> URL: https://issues.apache.org/jira/browse/WICKET-1679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Stefan Fußenegger
> Assignee: Matej Knopp
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> No entries are removed from DiskPageStore.sessionIdToEntryMap. I guess, this
> should be added to the DiskPageStore.unbind(String sessionId) method:
> public void unbind(String sessionId)
> {
> // FIX: replace get() with remove()
> SessionEntry entry =
> (SessionEntry)sessionIdToEntryMap.get(sessionId);
> if (entry != null)
> {
> if (isSynchronous())
> {
> entry.unbind();
> }
> else
> {
> List pages = getPagesToSaveList(sessionId);
> synchronized (pages)
> {
> flushPagesToSaveList(sessionId,
> pages);
> entry.unbind();
> }
> pagesToSaveAll.remove(sessionId);
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
