[
https://issues.apache.org/jira/browse/WICKET-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614667#action_12614667
]
Johan Compagner commented on WICKET-1637:
-----------------------------------------
this fix really breaks our code
if i do
setPageCreator(xxx)
then i dont except that i have to do that everytime.. Its a property that i set
on my modal window
Why is it set to null internally suddenly??
Byt the way we reused 1 instance of a ModalWindow all the time without any
problems (except now :( )
> ModalWindow can not be "reused"
> -------------------------------
>
> Key: WICKET-1637
> URL: https://issues.apache.org/jira/browse/WICKET-1637
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Matej Knopp
> Attachments: wicket-1637-modal-window-reuse.patch
>
>
> ModalWindow's methods setContent(Component) and setPageCreator() are not
> properly implemented. You should be able to call setContent() and
> setPageCreator() in sequence (or vice versa). However this will not work:
> I use one general purpose ModalWindow in my page to display several types of
> popups in it (of type 'component' and 'page')
> <body>
> <div wicket:id="popup"></div>
> ...
> </body>
> some of these popups use setPageCreator() others use setContent().
> however, once you use setContent(Component) you cannot use setPageCreator()
> anymore, because ModalWindow keeps the custom component / page creator stored
> and does not reset these properties as required.
> fix is attached (very simple, contains only two new lines :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
