[
https://issues.apache.org/jira/browse/WICKET-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624358#action_12624358
]
Sebastian Gooren commented on WICKET-1796:
------------------------------------------
a) tricky, as I expected. Of course, it should still be possible to have
properties in an XML file when the markup type is XML.
b) that would mean you need to cache that the given XML file cannot be handled,
to prevent it from being parsed/checked on every run. Not sure if you handle
that case; I know you cache properties the other way around (on succesfully
loading them).
My suggestion is this:
Put xml properties in files with a ".properties.xml" extension and (combined
with your option (a)) ignore ".xml" when the markup type is XML.
As a purist (haha) I would even say: drop the simple ".xml" extension for XML
properties, and always put them in a ".properties.xml" file. But unfortunately,
that would break all existing applications out there using simple ".xml"
properties files.
> When markup type is XML, getLocalizer().getString( "xyz", (WebPage) ) throws
> Exception
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1796
> URL: https://issues.apache.org/jira/browse/WICKET-1796
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4
> Environment: n/a
> Reporter: Sebastian Gooren
>
> When using
> @Override
> public String getMarkupType()
> {
> return "xml";
> }
> in a webpage, I cannot use getLocalizer().getString( "xyz", this ) anymore. I
> traced it back to
> Caused by: org.xml.sax.SAXParseException: Document root element "order", must
> match DOCTYPE root "null".
> Apparently, the wicket localizer
> (org.apache.wicket.resource.loader.ComponentStringResourceLoader.loadStringResource,
> line 142) decides to look for an XML properties file. Normally, this would
> be ok. But now, since I have an XML file in place which is the markup for the
> webpage, localization breaks. Wicket thinks that my markup file is an XML
> properties file.
> Right now it's either XML markup and no localization for that page, or HTML
> markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
