[
https://issues.apache.org/jira/browse/WICKET-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638080#action_12638080
]
Eelco Hillenius commented on WICKET-466:
----------------------------------------
Unfortunately, this patch has a few issues I disagree with.
* It breaks the API big time, whereas I think it should have been done in such
a way that it is backwards compatible.
* It misses documentation, such as an explanation of alternatives for methods/
classes that are marked deprecated
* I saw at least one instance of Locale.getDefault(), which should never be
used with Wicket (instead in this case just use the session's locale)
So... sorry but in the current state, I disagree with the patch.
> [datetime] Make DateConverter focus on joda-time.DateTime instead of util.Date
> ------------------------------------------------------------------------------
>
> Key: WICKET-466
> URL: https://issues.apache.org/jira/browse/WICKET-466
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-datetime
> Affects Versions: 1.3.0-beta1
> Reporter: Chuck Deal
> Assignee: Eelco Hillenius
> Priority: Minor
> Fix For: 1.4-M4
>
> Attachments: datetime.zip, datetime_patch.txt, datetime_patch.txt,
> datetime_patch.txt, datetime_patch.txt, datetime_patch.txt,
> quickstart-datetimeconverter.zip, wicket-datetime.patch
>
>
> I beleive the Wicket-datetime package was designed to be used with joda-time
> DateTime objects. It was also desirable to apply the "better"
> parsing/toString features of DateTime to util.Date objects. To that end, the
> attached patch improves the focus of the Converter to be DateTime oriented,
> while still allowing the DateTextField to hold util.Dates in it's model.
> The main idea of this patch is to make this package work with DateTime
> objects with very little effort on the developer's part. If they want to
> take advantage of the improved parsing, etc then it should take minimal
> effort.
> See http://www.nabble.com/-datetime--DateConverter-tf3233793.html for a brief
> history of this conversation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
