[
https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643810#action_12643810
]
Johan Compagner commented on WICKET-1220:
-----------------------------------------
i dont know if i like this change
i like the behavior (we in servoy have the exact same things and we also start
that the component you ask it for)
this could break a lot of code that depended on that the everything is checked
for example i do this in a behavior or something like that:
component.findParent(Form.class)
if you do that on a form class itself somehow then i expect to find it., after
this change i have to manually check the component itself first.
I guess renaming would be better then: visitHierachy() or something like that
Also we do that now already for years (i think from the beginning) as far as i
can see so this is quite a big behavior change. I dont like the behavior change
and i like the previous implementation better anyway. (just update docs i would
say)
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the
> call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method
> MarkupContainer.visitChildren() doesn't visit the calling component, but only
> it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
