[
https://issues.apache.org/jira/browse/WICKET-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644056#action_12644056
]
Jan Loose commented on WICKET-1905:
-----------------------------------
ad 1) yes page factory has nothing to do with urls .... and this is good for
me:-)
ad 2) no no no;-) I was thinking our usecases ... we have many of complex
panels with many and many components ... and this all functionallity is not
necessarily to create every request - if the page is bookmarkable - the hybrid
coding is solution for this in most of usecases, but in this case is hybrid
coding unusable ... because there is no way how to mount some page as / and
there is no way how to share instances between tabs in browser - to have two
views for the same instance of page (or there is other solution?).
> Component.getPageFactory() vs. Session.getPageFactory() and
> Session.getPageFactory(Page)
> ----------------------------------------------------------------------------------------
>
> Key: WICKET-1905
> URL: https://issues.apache.org/jira/browse/WICKET-1905
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
>
> I was found strange code:
> In Session:
> public final IPageFactory getPageFactory()
> {
> return getApplication().getSessionSettings().getPageFactory();
> }
> public final IPageFactory getPageFactory(final Page page)
> {
> if (page != null)
> {
> return page.getPageFactory();
> }
> return getPageFactory();
> }
> Both method are 'final', the first gets PageFactory from SessionSettings and
> the second uses Page#PageFactory (defined in Component) or uses the
> Session#getPageFactory() (the first method).
> In Component:
> /**
> * @return The page factory for the session that this component is in
> */
> public final IPageFactory getPageFactory()
> {
> return getSession().getPageFactory();
> }
> And again 'final' and gets the PageFactory by Session#getPageFactory() too.
> Why is there this code? I think that the final word in
> Component#getPageFactory() should be removed (i need it:-)).
> Thx,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
