[
https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654130#action_12654130
]
Stefan Simik commented on WICKET-1957:
--------------------------------------
Yes, Ryan - exactly the same we did in our application http://www.domenovac.sk.
We tried many solutions (for example ignore quietly incorrect parameters, ...),
but the final and best solution we found was to throw an 404 http error.
As you said, we can override error page (supported by servlet specifications in
web.xml) -> it is no problem to show our custom 404 page.
I also suggest to throw 404 error, when incorrect parameters.
Patch provided.
> Odd number of page parameters - should not throw IllegalStateException
> ----------------------------------------------------------------------
>
> Key: WICKET-1957
> URL: https://issues.apache.org/jira/browse/WICKET-1957
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.4-RC1
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Attachments:
> ExtendedBookmarkablePageRequestTargetUrlCodingStrategy.java
>
>
> The default URL strategy in wicket throws IllegalStateException, when there
> is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs
> manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are
> throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like
> DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring
> parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181) in RC1
> ------------------------------------------------------------------------------------
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with
> empty value "".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
