Author: jdonnerstag
Date: Sat Jan 17 06:26:28 2009
New Revision: 735297
URL: http://svn.apache.org/viewvc?rev=735297&view=rev
Log:
fixed wicket-2020: Callback after detaching the page but before the PageMap
lock is released
updated javadoc
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestCycle.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestCycle.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestCycle.java?rev=735297&r1=735296&r2=735297&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestCycle.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestCycle.java Sat
Jan 17 06:26:28 2009
@@ -188,6 +188,9 @@
/** MetaDataEntry array. */
private MetaDataEntry<?>[] metaData;
+ /** true if wicket handled this request, false otherwise */
+ private boolean handled = true;
+
/**
* Gets request cycle for calling thread.
*
@@ -1050,11 +1053,10 @@
}
/**
- * THIS METHOD IS WICKET PRIVATE API. DO NOT CALL UNLESS YOU KNOW WHAT
YOU ARE DOING.
- *
- * <p>
- * Clean up the request cycle.
- * </p>
+ * Clean up the request cycle. Please note that you (the user of
Wicket) will probably never
+ * have a need to call detach() yourself. It is used Wicket internally
only. But you may
+ * subclass RequestCycle in order to execute additional code during
detach. Do not forget to
+ * call super.detach() in or subclass.
*/
public void detach()
{
@@ -1161,7 +1163,6 @@
{
log.error("Exception occurred during threadDetach", re);
}
-
}
/**
@@ -1330,7 +1331,7 @@
}
/**
- * INTERNAL. This method is not part of public Wicket Api. Do not call
it. Returns whether
+ * INTERNAL. THIS METHOD IS NOT PART OF PUBLIC WICKET API. Do not call
it. Returns whether
* wicket handled this request or not (i.e. when no request target was
found).
*
* @return true if wicket handled this request, false otherwise
@@ -1340,8 +1341,6 @@
return handled;
}
- private boolean handled = true;
-
/**
* Loop through the processing steps starting from the current one.
*/
