[
https://issues.apache.org/jira/browse/WICKET-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667206#action_12667206
]
Emond Papegaaij commented on WICKET-2020:
-----------------------------------------
Overriding detach() in our base page is not reliable, because it requires all
subclasses that currently override detach() to first detach their own models
and then call super.detach() (otherwise the check will be executed before all
models are detached). The problem lies in the fact that detach() IS the detach
phase, which makes it difficult to check if the detach HAS BEEN performed
correctly.
> Callback after detaching the page but before the PageMap lock is released
> -------------------------------------------------------------------------
>
> Key: WICKET-2020
> URL: https://issues.apache.org/jira/browse/WICKET-2020
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Emond Papegaaij
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC2
>
>
> Currently, it is not possible to perform any checks on a page after the
> request has been detached. In onEndRequest, the PageMap lock has already been
> cleared, making it unsafe to access the pages involved in the request. Would
> it be possible to add an extra callback method (ie. onAfterTargetDetach()) to
> RequestCycle directly after detaching the request targets? We need such a
> callback to check (in development mode) if all models are detached correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
