[ 
https://issues.apache.org/jira/browse/WICKET-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677845#action_12677845
 ] 

Igor Vaynberg commented on WICKET-2126:
---------------------------------------

i dont mind removing the widening. i think it sucks that if you have a 
imodel<list<user>> you cannot reuse it for a listview or for dropdownchoice 
choices model.

i was not a fan of widening to start with, i think the argument that if you 
write a component to deal with users and will want to reuse it for dealing with 
subclasses of users is very thin. if it ever comes up all you have to do is 
wrap the models you pass in and cast them - which is trivial. usually if you 
have dropdownchoice<user> you will be giving it users, not admins.

but, other users wanted widened collections, maybe they have good usecases. 
what needs to happen is another vote if we are to remove this. and it better 
happen quickly because removing widening will cause compile errors and we are 
already close to rc3.



> Widen generics for ListView model (should be List<? extends T> and not just 
> List<T>)
> ------------------------------------------------------------------------------------
>
>                 Key: WICKET-2126
>                 URL: https://issues.apache.org/jira/browse/WICKET-2126
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-RC2
>            Reporter: Timo Rantalaiho
>            Assignee: Timo Rantalaiho
>         Attachments: WICKET-2126_widen_ListView_generics.patch
>
>
> See WICKET-1512
> See mailing list: 
> http://www.nabble.com/LDM-with-Generics-for-DropDownChoice-td22155211.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to