[
https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681464#action_12681464
]
Jeremy Thomerson commented on WICKET-2137:
------------------------------------------
I reviewed the attached patch and supplied these comments on the mailing list:
Unless I'm seeing double - this patch has two problems:
1 - It is the opposite of what was voted on. The vote was to make
IModel<List<? extends E>> into IModel<List<E>>. Your patch makes it IModel<?
extends List<? extends E>>.
2 - The patch causes compile errors that were not fixed.
I have unassigned myself from the task until those issues are addressed or I
have time to create my own patch. The best solution would be for someone to
submit a proper patch that fixes the two problems above or explain to me what I
missed.
Thanks!
> Synchronize generics between ListView and DropDownChoice
> --------------------------------------------------------
>
> Key: WICKET-2137
> URL: https://issues.apache.org/jira/browse/WICKET-2137
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC3
> Environment: 1.4-SNAPSHOT as of 2009-01-28
> Reporter: Brill Pappin
> Attachments: TestGenerics.java, WICKET-2137.patch
>
>
> DropDownChoice has a generics definition of List<? extends T> in its
> constructor.
> This causes trouble with existing models that may be used in a DropDownChoice
> and is not consistant with ListView which uses <List<T>>.
> Change DropDownChoice to match the other list type components so that their
> models can be used across components.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
