[
https://issues.apache.org/jira/browse/WICKET-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-2171.
----------------------------------------
Resolution: Invalid
Fix Version/s: 1.4-RC3
Assignee: Juergen Donnerstag
This is the javadoc. It clearly states that "... This Base64 encoder is
modified to meet URL requirements. The changes are .... "
/**
* Provides Base64 encoding and decoding with URL and filename safe alphabet as
defined by RFC 3548,
* section 4. <p/> This Base64 encoder is modified to meet URL requirements.
The changes are: '+' =>
* '*', '/' => '-', and no padding. <p/> This class is taken from the Apache
commons-codec, and
> Base64UrlSafe claims to be RFC 3548 compliant, but isn't
> --------------------------------------------------------
>
> Key: WICKET-2171
> URL: https://issues.apache.org/jira/browse/WICKET-2171
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC2
> Reporter: Jonas
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4-RC3
>
>
> The javadoc of Base64UrlSafe claims to use the alphabet defined in RFC 3548,
> section 4 [1].
> This isn't true, it uses '*' for 62 instead of '-' and '-' for 63 instead of
> '_'.
> I suggest to make the code RFC compliant.
> If you decide not to make it RFC compliant, at least to let the javadoc
> clearly state
> that the changes made to Base64UrlSafe breaks compatibility with other Base64
> RFC 3548, section 4
> compliant encoders/decoders.
> [1] http://www.faqs.org/rfcs/rfc3548.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
