Check component id against invalid chars ':' and '.'
----------------------------------------------------

                 Key: WICKET-2184
                 URL: https://issues.apache.org/jira/browse/WICKET-2184
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4-RC2
            Reporter: Juergen Donnerstag


Currently we are only testing a component id not to be null. However ':' and 
'.' are effectively invalid chars as well. ":" is used as separator between 
path component and "." is used to find properties like myComponent.Required

Component.java should be modified as follows:

        final void setId(final String id)
        {
                if (!(this instanceof Page))
                {
                        if (Strings.isEmpty(id))
                        {
                                throw new WicketRuntimeException("Null or empty 
component id is not allowed.");
                        }

                        if ((id.indexOf('.') != -1) || (id.indexOf(':') != -1))
                        {
                                throw new WicketRuntimeException("The component 
id must not contain a '.' or ':'.");
                        }
                }
                this.id = id;
        }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to