svn commit: r763129 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/util/tester/FormTester.java test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java

[jdonnerstag]

Author: jdonnerstag
Date: Wed Apr  8 07:28:04 2009
New Revision: 763129

URL: http://svn.apache.org/viewvc?rev=763129&view=rev
Log:
fixed WICKET-2124 FormTester.setValue should throw excecption if the component 
does not exist
Issue: WICKET-2124

Modified:
    
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java
    
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java?rev=763129&r1=763128&r2=763129&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java 
(original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java 
Wed Apr  8 07:28:04 2009
@@ -567,6 +567,11 @@
                checkClosed();
 
                Component component = workingForm.get(formComponentId);
+               if (component == null)
+               {
+                       throw new IllegalArgumentException(
+                               "Unable to set value. Couldn't find component 
with name: " + formComponentId);
+               }
                if (component instanceof IFormSubmittingComponent)
                {
                        
setFormSubmittingComponentValue((IFormSubmittingComponent)component, value);

Modified: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java?rev=763129&r1=763128&r2=763129&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java
 (original)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/border/TestHomePage_2134.java
 Wed Apr  8 07:28:04 2009
@@ -66,7 +66,7 @@
 
                FormTester formTester = tester.newFormTester("border:form1");
                formTester.setValue("quantity1", "123");
-               formTester.setValue("quantity2", "44");
+               // formTester.setValue("quantity2", "44");
                formTester.submit();
 
                CommonModelPage page = 
(CommonModelPage)tester.getLastRenderedPage();
@@ -86,7 +86,7 @@
                tester.assertRenderedPage(CommonModelPage.class);
 
                FormTester formTester = tester.newFormTester("border:form2");
-               formTester.setValue("quantity1", "123");
+               // formTester.setValue("quantity1", "123");
                formTester.setValue("quantity2", "44");
                formTester.submit();