[ 
https://issues.apache.org/jira/browse/WICKET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-2064.
-----------------------------------

    Resolution: Won't Fix
      Assignee: Igor Vaynberg

it is reset in detach() because the value does not need to be persisted with 
the component, it will be recalculated again. i say we leave it until it is a 
hotspot in the profiler just because the code already works and is not causing 
any trouble. we can revisit it in 1.5 if need be.

> Make Component.ENABLED_IN_HIERARCHY_CACHE_KEY a instance variable rather than 
> a MetaDataKey
> -------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2064
>                 URL: https://issues.apache.org/jira/browse/WICKET-2064
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC1
>            Reporter: Juergen Donnerstag
>            Assignee: Igor Vaynberg
>            Priority: Minor
>
> Component.ENABLED_IN_HIERARCHY_CACHE_KEY currently is a MetaDataKey which get 
> added to each Component if isEnableInHierarchy is invoked. That basically 
> happens all the time. In contrast the concept of MetaData has been introduced 
> to allow rarely used data to be attached to Components (with java 1.5 in a 
> typesafe manner). Since MetaData introduce some overhead, and for simplicity 
> reasons, I'd suggest to convert Component.ENABLED_IN_HIERARCHY_CACHE_KEY into 
> a Boolean instance variable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to